Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add trace context injection and Logger limit to Logging SDK #15

Closed
wants to merge 1 commit into from
Closed

Add trace context injection and Logger limit to Logging SDK #15

wants to merge 1 commit into from

Conversation

MarkSeufert
Copy link

@MarkSeufert MarkSeufert commented Dec 4, 2020 •
edited
Loading

This PR makes two additions to the logging SDK:

  • The SDK’s Logger injects fields of the LogRecord if the user didn’t specify them. The fields that get injected are timestamp, severity, traceid, spanid, and traceflags
  • Added a logger limit to the SDK LoggerProvider (relevant spec issue), which returns a noop logger if the limit has been reached.
  • Unit tests for the above functionality

The CI tests will fail until the recent API PR gets merged, since it uses some of the changes made from it.

@MarkSeufert MarkSeufert changed the title Updating Logging SDK and processor Logging SDK Injection and Logger Limit Dec 8, 2020
@kxyr kxyr changed the title Logging SDK Injection and Logger Limit Add context injection and Logger limit to Logging SDK Dec 9, 2020
@kxyr kxyr changed the title Add context injection and Logger limit to Logging SDK Add trace context injection and Logger limit to Logging SDK Dec 9, 2020
@kxyr kxyr closed this Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MarkSeufert @kxyr